netdev - Re: [PATCH net-next 2/3] cxgb4: add UDP segmentation offload support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 21 Nov 2019 12:02:18 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     rahul.lakkireddy@...lsio.com
Cc:     netdev@...r.kernel.org, linux-crypto@...r.kernel.org,
        herbert@...dor.apana.org.au, nirranjan@...lsio.com,
        atul.gupta@...lsio.com, vishal@...lsio.com, dt@...lsio.com
Subject: Re: [PATCH net-next 2/3] cxgb4: add UDP segmentation offload
 support

From: Rahul Lakkireddy <rahul.lakkireddy@...lsio.com>
Date: Thu, 21 Nov 2019 20:50:48 +0530

> @@ -1345,6 +1355,25 @@ static inline int cxgb4_validate_skb(struct sk_buff *skb,
>  	return 0;
>  }
>  
> +static inline void *write_eo_udp_wr(struct sk_buff *skb,
> +				    struct fw_eth_tx_eo_wr *wr, u32 hdr_len)
> +{

Do not use inline in foo.c files, let the compiler decide.

I know this source file is already a rotting mess of inline function
directives, but let's not add more.