netdev - Re: [PATCH net-next 2/2] net: sfp: add some quirks for GPON modules

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191120161427.2921e210@cakuba.netronome.com>
Date:   Wed, 20 Nov 2019 16:14:27 -0800
From:   Jakub Kicinski <jakub.kicinski@...ronome.com>
To:     Russell King - ARM Linux admin <linux@...linux.org.uk>
Cc:     Andrew Lunn <andrew@...n.ch>,
        Florian Fainelli <f.fainelli@...il.com>,
        Heiner Kallweit <hkallweit1@...il.com>,
        "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: [PATCH net-next 2/2] net: sfp: add some quirks for GPON modules

On Thu, 21 Nov 2019 00:03:28 +0000, Russell King - ARM Linux admin
wrote:
> On Wed, Nov 20, 2019 at 02:46:32PM -0800, Jakub Kicinski wrote:
> > On Wed, 20 Nov 2019 11:42:47 +0000, Russell King wrote:  
> > >  static const struct sfp_quirk sfp_quirks[] = {
> > > +	{
> > > +		// Alcatel Lucent G-010S-P can operate at 2500base-X, but
> > > +		// incorrectly report 2500MBd NRZ in their EEPROM
> > > +		.vendor = "ALCATELLUCENT",
> > > +		.part = "G010SP",
> > > +		.modes = sfp_quirk_2500basex,
> > > +	}, {
> > > +		// Alcatel Lucent G-010S-A can operate at 2500base-X, but
> > > +		// report 3.2GBd NRZ in their EEPROM
> > > +		.vendor = "ALCATELLUCENT",
> > > +		.part = "3FE46541AA",
> > > +		.modes = sfp_quirk_2500basex,
> > > +	}, {
> > > +		// Huawei MA5671A can operate at 2500base-X, but report 1.2GBd
> > > +		// NRZ in their EEPROM
> > > +		.vendor = "HUAWEI",
> > > +		.part = "MA5671A",
> > > +		.modes = sfp_quirk_2500basex,
> > > +	},
> > >  };  
> > 
> > nit: no C++ comment style?  
> 
> Did you read Linus' opinions on commentry style during the discussion
> over the SPDX tags?
> 
> https://lkml.org/lkml/2017/11/2/715
> https://lkml.org/lkml/2017/11/25/133
> 
> It seems that Linus has decided to prefer // over /* */

Yeah, I remember that, I did:

$ git grep '// ' drivers/net/phy/ | grep -v SPDX
drivers/net/phy/microchip_t1.c:// Copyright (C) 2018 Microchip Technology

before I asked, and assumed since for the last two years they didn't
gain much popularity in this corner of the kernel it's worth asking if
this is intentional :)