netdev - RE: [PATCH net] r8152: Re-order napi_disable in rtl8152

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2b96129da21d412f8780325e6be95c9d@realtek.com>
Date:   Thu, 21 Nov 2019 03:00:00 +0000
From:   Hayes Wang <hayeswang@...ltek.com>
To:     Prashant Malani <pmalani@...omium.org>
CC:     "grundler@...omium.org" <grundler@...omium.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        nic_swsd <nic_swsd@...ltek.com>
Subject: RE: [PATCH net] r8152: Re-order napi_disable in rtl8152_close

Prashant Malani [mailto:pmalani@...omium.org]
> Sent: Thursday, November 21, 2019 3:40 AM
[...]
> @@ -4283,10 +4283,10 @@ static int rtl8152_close(struct net_device
> *netdev)
>  	unregister_pm_notifier(&tp->pm_notifier);
>  #endif
>  	tasklet_disable(&tp->tx_tl);

Should tasklet_disable() be moved, too?

> -	napi_disable(&tp->napi);
>  	clear_bit(WORK_ENABLE, &tp->flags);
>  	usb_kill_urb(tp->intr_urb);
>  	cancel_delayed_work_sync(&tp->schedule);
> +	napi_disable(&tp->napi);
>  	netif_stop_queue(netdev);

Best Regards,
Hayes