netdev - Re: [PATCH net-next] audit: Move audit_log_task declaration under CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a39cbda4-a1e4-ddc8-6ecf-046ccfb3d584@iogearbox.net>
Date:   Thu, 21 Nov 2019 21:38:48 +0100
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Jiri Olsa <jolsa@...nel.org>,
        "David S. Miller" <davem@...emloft.net>
Cc:     kbuild test robot <lkp@...el.com>, netdev@...r.kernel.org,
        Steve Grubb <sgrubb@...hat.com>,
        Alexei Starovoitov <ast@...nel.org>
Subject: Re: [PATCH net-next] audit: Move audit_log_task declaration under
 CONFIG_AUDITSYSCALL

On 11/21/19 4:58 PM, Jiri Olsa wrote:
> The 0-DAY found that audit_log_task is not declared under
> CONFIG_AUDITSYSCALL which causes compilation error when
> it is not defined:
> 
>      kernel/bpf/syscall.o: In function `bpf_audit_prog.isra.30':
>   >> syscall.c:(.text+0x860): undefined reference to `audit_log_task'
> 
> Adding the audit_log_task declaration and stub within
> CONFIG_AUDITSYSCALL ifdef.
> 
> Fixes: 91e6015b082b ("bpf: Emit audit messages upon successful prog load and unload")
> Reported-by: kbuild test robot <lkp@...el.com>
> Signed-off-by: Jiri Olsa <jolsa@...nel.org>

Acked-by: Daniel Borkmann <daniel@...earbox.net>