netdev - RE: [PATCH 4/5] net: dsa: ocelot: define PTP registers for felix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <VI1PR0401MB2237B04F05439429F3D66D44F84E0@VI1PR0401MB2237.eurprd04.prod.outlook.com>
Date:   Thu, 21 Nov 2019 03:20:52 +0000
From:   "Y.b. Lu" <yangbo.lu@....com>
To:     Andrew Lunn <andrew@...n.ch>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Microchip Linux Driver Support <UNGLinuxDriver@...rochip.com>,
        "David S . Miller" <davem@...emloft.net>,
        Vladimir Oltean <vladimir.oltean@....com>,
        Claudiu Manoil <claudiu.manoil@....com>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        Richard Cochran <richardcochran@...il.com>
Subject: RE: [PATCH 4/5] net: dsa: ocelot: define PTP registers for
 felix_vsc9959

Hi Andrew,

> -----Original Message-----
> From: Andrew Lunn <andrew@...n.ch>
> Sent: Thursday, November 21, 2019 10:49 AM
> To: Y.b. Lu <yangbo.lu@....com>
> Cc: netdev@...r.kernel.org; Alexandre Belloni
> <alexandre.belloni@...tlin.com>; Microchip Linux Driver Support
> <UNGLinuxDriver@...rochip.com>; David S . Miller <davem@...emloft.net>;
> Vladimir Oltean <vladimir.oltean@....com>; Claudiu Manoil
> <claudiu.manoil@....com>; Vivien Didelot <vivien.didelot@...il.com>;
> Florian Fainelli <f.fainelli@...il.com>; Richard Cochran
> <richardcochran@...il.com>
> Subject: Re: [PATCH 4/5] net: dsa: ocelot: define PTP registers for
> felix_vsc9959
> 
> > +static const u32 vsc9959_ptp_regmap[] = {
> > +	REG(PTP_PIN_CFG,                   0x000000),
> > +	REG(PTP_PIN_TOD_SEC_MSB,           0x000004),
> > +	REG(PTP_PIN_TOD_SEC_LSB,           0x000008),
> > +	REG(PTP_PIN_TOD_NSEC,              0x00000c),
> > +	REG(PTP_CFG_MISC,                  0x0000a0),
> > +	REG(PTP_CLK_CFG_ADJ_CFG,           0x0000a4),
> > +	REG(PTP_CLK_CFG_ADJ_FREQ,          0x0000a8),
> > +};
> > +
> 
> > +	[PTP] = {
> > +		.start	= 0x0090000,
> > +		.end	= 0x00900cb,
> > +		.name	= "ptp",
> > +	},
> 
> Seems like an odd end value. Is the last word used for something else?
> 
> Also, the last regmap register you defined is 0xa8. So could end actually be
> 900ab?

[Y.b. Lu] The PTP registers range is from 0x0090000 to 0x00900cb according to reference manual.
The patch has only defined the registers which ocelot driver is using now, not all registers in vsc9959_ptp_regmap.

In the future, as new features will be added, I think more registers will be added to use.
Thanks.
> 
> 	 Andrew