netdev - RE: [net-next v2] tipc: support in-order name publication events

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <00f001d5a039$7a0d7520$6e285f60$@dektech.com.au>
Date:   Thu, 21 Nov 2019 14:01:17 +0700
From:   "Tuong Lien Tong" <tuong.t.lien@...tech.com.au>
To:     "'David Miller'" <davem@...emloft.net>
Cc:     <jon.maloy@...csson.com>, <maloy@...jonn.com>,
        <ying.xue@...driver.com>, <netdev@...r.kernel.org>,
        <tipc-discussion@...ts.sourceforge.net>
Subject: RE: [net-next v2] tipc: support in-order name publication events

Hi David,

The fact is we still want to keep it with that explicit meaning, so make the
code easy to understand. Yes, the 'time_after32()' or another macro can give
the same result but makes no sense in this particular scenario. Otherwise,
do you like something such as:

#define publication_after(...) time_after32(...)

BR/Tuong

-----Original Message-----
From: David Miller <davem@...emloft.net> 
Sent: Thursday, November 21, 2019 1:14 PM
To: tuong.t.lien@...tech.com.au
Cc: jon.maloy@...csson.com; maloy@...jonn.com; ying.xue@...driver.com;
netdev@...r.kernel.org; tipc-discussion@...ts.sourceforge.net
Subject: Re: [net-next v2] tipc: support in-order name publication events

From: Tuong Lien <tuong.t.lien@...tech.com.au>
Date: Thu, 21 Nov 2019 09:53:25 +0700

> +static inline int publication_after(struct publication *pa,
> +				    struct publication *pb)
> +{
> +	return ((int)(pb->id - pa->id) < 0);
> +}

Juse use time32_after() et al. instead of reinventing the same exact
code please.