netdev - RE: [PATCH v2 bpf-next 1/9] bpf: add bpf_map_{value_size,update_value,map_copy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5dd80ea2da121_690a2ae784a225c44f@john-XPS-13-9370.notmuch>
Date:   Fri, 22 Nov 2019 08:36:50 -0800
From:   John Fastabend <john.fastabend@...il.com>
To:     Brian Vazquez <brianvv@...gle.com>,
        Brian Vazquez <brianvv.kernel@...il.com>,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        "David S . Miller" <davem@...emloft.net>
Cc:     Yonghong Song <yhs@...com>, Stanislav Fomichev <sdf@...gle.com>,
        Petar Penkov <ppenkov@...gle.com>,
        Willem de Bruijn <willemb@...gle.com>,
        linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
        bpf@...r.kernel.org, Brian Vazquez <brianvv@...gle.com>
Subject: RE: [PATCH v2 bpf-next 1/9] bpf: add
 bpf_map_{value_size,update_value,map_copy_value} functions

Brian Vazquez wrote:
> This commit moves reusable code from map_lookup_elem and map_update_elem
> to avoid code duplication in kernel/bpf/syscall.c.
> 
> Signed-off-by: Brian Vazquez <brianvv@...gle.com>
> ---
>  kernel/bpf/syscall.c | 271 ++++++++++++++++++++++++-------------------
>  1 file changed, 151 insertions(+), 120 deletions(-)
> 

Nice bit of cleanup.

Acked-by: John Fastabend <john.fastabend@...il.com>