netdev - Re: [PATCH net] r8152: avoid to call napi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20191122.100842.1368735892662020130.davem@davemloft.net>
Date:   Fri, 22 Nov 2019 10:08:42 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     hayeswang@...ltek.com
Cc:     netdev@...r.kernel.org, nic_swsd@...ltek.com,
        linux-kernel@...r.kernel.org, pmalani@...omium.org,
        grundler@...omium.org
Subject: Re: [PATCH net] r8152: avoid to call napi_disable twice

From: Hayes Wang <hayeswang@...ltek.com>
Date: Fri, 22 Nov 2019 16:21:09 +0800

> Call napi_disable() twice would cause dead lock. There are three situations
> may result in the issue.
> 
> 1. rtl8152_pre_reset() and set_carrier() are run at the same time.
> 2. Call rtl8152_set_tunable() after rtl8152_close().
> 3. Call rtl8152_set_ringparam() after rtl8152_close().
> 
> For #1, use the same solution as commit 84811412464d ("r8152: Re-order
> napi_disable in rtl8152_close"). For #2 and #3, add checking the flag
> of IFF_UP and using napi_disable/napi_enable during mutex.
> 
> Signed-off-by: Hayes Wang <hayeswang@...ltek.com>

Applied and queued up for -stable, thanks.