netdev - Re: [PATCH net-next 3/3] dpaa2-eth: return all supported link modes in PHY_INTERFACE_MODE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20191122002743.GF25745@shell.armlinux.org.uk>
Date:   Fri, 22 Nov 2019 00:27:43 +0000
From:   Russell King - ARM Linux admin <linux@...linux.org.uk>
To:     Ioana Ciornei <ioana.ciornei@....com>
Cc:     davem@...emloft.net, netdev@...r.kernel.org, andrew@...n.ch
Subject: Re: [PATCH net-next 3/3] dpaa2-eth: return all supported link modes
 in PHY_INTERFACE_MODE_NA

On Thu, Nov 21, 2019 at 09:15:27PM +0200, Ioana Ciornei wrote:
> The include/linux/phylink.h states:
>  * When @state->interface is %PHY_INTERFACE_MODE_NA, phylink expects
>  * MAC driver to return all supported link modes.
> 
> Make the necessary adjustment to meet the requirements.
> 
> Signed-off-by: Ioana Ciornei <ioana.ciornei@....com>

This is independent of patch 1.

Acked-by: Russell King <rmk+kernel@...linux.org.uk>

> ---
>  drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c b/drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c
> index efc587515661..d93d71724e5a 100644
> --- a/drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c
> +++ b/drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c
> @@ -95,6 +95,7 @@ static void dpaa2_mac_validate(struct phylink_config *config,
>  	phylink_set(mask, Asym_Pause);
>  
>  	switch (state->interface) {
> +	case PHY_INTERFACE_MODE_NA:
>  	case PHY_INTERFACE_MODE_RGMII:
>  	case PHY_INTERFACE_MODE_RGMII_ID:
>  	case PHY_INTERFACE_MODE_RGMII_RXID:
> -- 
> 1.9.1
> 
> 

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
According to speedtest.net: 11.9Mbps down 500kbps up