netdev - Re: [PATCH bpf-next] bpf: add bpf_jit_blinding_enabled for !CONFIG_BPF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 23 Nov 2019 13:04:26 -0800
From:   Alexei Starovoitov <alexei.starovoitov@...il.com>
To:     Daniel Borkmann <daniel@...earbox.net>
Cc:     Alexei Starovoitov <ast@...nel.org>,
        Jakub Sitnicki <jakub@...udflare.com>,
        Andrii Nakryiko <andrii.nakryiko@...il.com>,
        Network Development <netdev@...r.kernel.org>,
        bpf <bpf@...r.kernel.org>, Andrii Nakryiko <andriin@...com>
Subject: Re: [PATCH bpf-next] bpf: add bpf_jit_blinding_enabled for !CONFIG_BPF_JIT

On Sat, Nov 23, 2019 at 12:37 PM Daniel Borkmann <daniel@...earbox.net> wrote:
>
> Add a definition of bpf_jit_blinding_enabled() when CONFIG_BPF_JIT is not set
> in order to fix a recent build regression:
>
>   [...]
>   CC      kernel/bpf/verifier.o
>   CC      kernel/bpf/inode.o
> kernel/bpf/verifier.c: In function ‘fixup_bpf_calls’:
> kernel/bpf/verifier.c:9132:25: error: implicit declaration of function ‘bpf_jit_blinding_enabled’; did you mean ‘bpf_jit_kallsyms_enabled’? [-Werror=implicit-function-declaration]
>  9132 |  bool expect_blinding = bpf_jit_blinding_enabled(prog);
>       |                         ^~~~~~~~~~~~~~~~~~~~~~~~
>       |                         bpf_jit_kallsyms_enabled
>   CC      kernel/bpf/helpers.o
>   CC      kernel/bpf/hashtab.o
>   [...]
>
> Fixes: bad63c9ea554 ("bpf: Constant map key tracking for prog array pokes")
> Reported-by: Jakub Sitnicki <jakub@...udflare.com>
> Reported-by: Andrii Nakryiko <andriin@...com>
> Signed-off-by: Daniel Borkmann <daniel@...earbox.net>

Applied. Thanks