netdev - Re: [PATCH V2 net-next 3/6] net/mlxfw: Improve FSM err message reporting and return codes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 23 Nov 2019 17:00:46 -0800
From:   Jakub Kicinski <jakub.kicinski@...ronome.com>
To:     Saeed Mahameed <saeedm@...lanox.com>
Cc:     "David S. Miller" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Jiri Pirko <jiri@...lanox.com>,
        Ido Schimmel <idosch@...lanox.com>,
        David Ahern <dsahern@...il.com>,
        Johannes Berg <johannes@...solutions.net>
Subject: Re: [PATCH V2 net-next 3/6] net/mlxfw: Improve FSM err message
 reporting and return codes

On Fri, 22 Nov 2019 22:41:50 +0000, Saeed Mahameed wrote:
> +	NL_SET_ERR_MSG_MOD(extack, MLXFW_ERR_PRFX "%s",
> +			   mlxfw_fsm_state_err_str[fsm_state_err]);

Things like this also require a word of comment, because the intention
of wrapping all extact strings into the macro IIRC was to mark them for
possible translation. 

IDK if we still care about that (IMHO we should), we probably need at
least a new macro for cases like this so the strings in the error table
are marked for extraction for translators as well, no?