netdev - Re: [PATCH v2 net-next] net: core: use listified Rx for GRO_NORMAL in napi_gro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <PSXP216MB04382C21FF000C9A516324D4804A0@PSXP216MB0438.KORP216.PROD.OUTLOOK.COM>
Date:   Mon, 25 Nov 2019 13:07:01 +0000
From:   Nicholas Johnson <nicholas.johnson-opensource@...look.com.au>
To:     Paolo Abeni <pabeni@...hat.com>
CC:     Johannes Berg <johannes@...solutions.net>,
        Alexander Lobakin <alobakin@...nk.ru>,
        Edward Cree <ecree@...arflare.com>,
        David Miller <davem@...emloft.net>,
        "jiri@...lanox.com" <jiri@...lanox.com>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        "idosch@...lanox.com" <idosch@...lanox.com>,
        "petrm@...lanox.com" <petrm@...lanox.com>,
        "sd@...asysnail.net" <sd@...asysnail.net>,
        "f.fainelli@...il.com" <f.fainelli@...il.com>,
        "jaswinder.singh@...aro.org" <jaswinder.singh@...aro.org>,
        "ilias.apalodimas@...aro.org" <ilias.apalodimas@...aro.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "emmanuel.grumbach@...el.com" <emmanuel.grumbach@...el.com>,
        "luciano.coelho@...el.com" <luciano.coelho@...el.com>,
        "linuxwifi@...el.com" <linuxwifi@...el.com>,
        "kvalo@...eaurora.org" <kvalo@...eaurora.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>
Subject: Re: [PATCH v2 net-next] net: core: use listified Rx for GRO_NORMAL in
 napi_gro_receive()

On Mon, Nov 25, 2019 at 12:42:44PM +0100, Paolo Abeni wrote:
> I think it would be nice moving the iwlwifi driver to full/plain NAPI
> mode. The interrupt handler could keep processing extra work as it does
> now and queue real pkts on some internal queue, and than schedule the
> relevant napi, which in turn could process such queue in the napi poll
> method. Likely I missed tons of details and/or oversimplified it...

It must have something to do with iwlwifi (as if we needed more 
evidence). I just booted a different variant of the Dell XPS 9370 which 
has Qualcomm Wi-Fi [168c:003e] (ath10k_pci.ko), instead of Intel Wi-Fi, 
from the same USB SSD as before, and it has no issues whatsoever.

My regression report quickly blown up to be way over my head in terms of 
understanding, but I will keep monitoring the discussions and try to 
learn from it. Everybody, please keep me CC'd into any further 
communications with driver teams, as I am genuinely interested in the 
journey and the outcome.

> Cheers,
> 
> Paolo
> 
> 
Cheers,
Nicholas