netdev - Re: [PATCH v2 net-next] net: core: use listified Rx for GRO_NORMAL in napi_gro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 25 Nov 2019 13:21:49 +0000
From:   Edward Cree <ecree@...arflare.com>
To:     Alexander Lobakin <alobakin@...nk.ru>,
        Paolo Abeni <pabeni@...hat.com>
CC:     Johannes Berg <johannes@...solutions.net>,
        Nicholas Johnson <nicholas.johnson-opensource@...look.com.au>,
        David Miller <davem@...emloft.net>, <jiri@...lanox.com>,
        <edumazet@...gle.com>, <idosch@...lanox.com>, <petrm@...lanox.com>,
        <sd@...asysnail.net>, <f.fainelli@...il.com>,
        <jaswinder.singh@...aro.org>, <ilias.apalodimas@...aro.org>,
        <linux-kernel@...r.kernel.org>, <emmanuel.grumbach@...el.com>,
        <luciano.coelho@...el.com>, <linuxwifi@...el.com>,
        <kvalo@...eaurora.org>, <netdev@...r.kernel.org>,
        <linux-wireless@...r.kernel.org>
Subject: Re: [PATCH v2 net-next] net: core: use listified Rx for GRO_NORMAL in
 napi_gro_receive()

On 25/11/2019 12:02, Alexander Lobakin wrote:
> I'm not very familiar with iwlwifi, but as a work around manual
> napi_gro_flush() you can also manually flush napi->rx_list to
> prevent packets from stalling:
>
> diff -Naur a/drivers/net/wireless/intel/iwlwifi/pcie/rx.c b/drivers/net/wireless/intel/iwlwifi/pcie/rx.c
> --- a/drivers/net/wireless/intel/iwlwifi/pcie/rx.c    2019-11-25 14:55:03.610355230 +0300
> +++ b/drivers/net/wireless/intel/iwlwifi/pcie/rx.c    2019-11-25 14:57:29.399556868 +0300
> @@ -1526,8 +1526,16 @@
>      if (unlikely(emergency && count))
>          iwl_pcie_rxq_alloc_rbs(trans, GFP_ATOMIC, rxq);
>
> -    if (rxq->napi.poll)
> +    if (rxq->napi.poll) {
> +        if (rxq->napi.rx_count) {
> +            netif_receive_skb_list(&rxq->napi.rx_list);
> +
> +            INIT_LIST_HEAD(&rxq->napi.rx_list);
> +            rxq->napi.rx_count = 0;
> +        }
> +
>          napi_gro_flush(&rxq->napi, false);
> +    }
>
>      iwl_pcie_rxq_restock(trans, rxq);
>  }
... or we could export gro_normal_list(), instead of open-coding it
 in the driver?

-Ed