netdev - Re: [PATCH] net: phy: Use the correct style for SPDX License Identifier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20191125143900.GA2572@nishad>
Date:   Mon, 25 Nov 2019 20:09:10 +0530
From:   Nishad Kamdar <nishadkamdar@...il.com>
To:     Jakub Kicinski <jakub.kicinski@...ronome.com>,
        Andrew Lunn <andrew@...n.ch>,
        Florian Fainelli <f.fainelli@...il.com>,
        Heiner Kallweit <hkallweit1@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Maxime Coquelin <mcoquelin.stm32@...il.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Joe Perches <joe@...ches.com>,
        Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: phy: Use the correct style for SPDX License
 Identifier

On Sat, Nov 23, 2019 at 06:34:55PM -0800, Jakub Kicinski wrote:
> On Sat, 23 Nov 2019 18:38:19 +0530, Nishad Kamdar wrote:
> > diff --git a/drivers/net/phy/aquantia.h b/drivers/net/phy/aquantia.h
> > index 5a16caab7b2f..40e0be0f4e1c 100644
> > --- a/drivers/net/phy/aquantia.h
> > +++ b/drivers/net/phy/aquantia.h
> > @@ -1,5 +1,5 @@
> > -/* SPDX-License-Identifier: GPL-2.0
> > - * HWMON driver for Aquantia PHY
> > +/* SPDX-License-Identifier: GPL-2.0 */
> > +/*  HWMON driver for Aquantia PHY
> 
> You're adding an extra space here. Is this intentional?

No, It shouldn't be there.

Thanks you for pointing it out.
I'll update and resend the patch.

Thanks for the review.

Regards,
Nishad

> 
> >   *
> >   * Author: Nikita Yushchenko <nikita.yoush@...entembedded.com>
> >   * Author: Andrew Lunn <andrew@...n.ch>