[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20191125090530.5e34fc93@cakuba.netronome.com>
Date: Mon, 25 Nov 2019 09:05:30 -0800
From: Jakub Kicinski <jakub.kicinski@...ronome.com>
To: Martin Varghese <martinvarghesenokia@...il.com>
Cc: netdev@...r.kernel.org, pshelar@....org, davem@...emloft.net,
jhs@...atatu.com, xiyou.wangcong@...il.com, jiri@...nulli.us,
martin.varghese@...ia.com
Subject: Re: [PATCH v2 net-next] Enhanced skb_mpls_pop to update ethertype
of the packet in all the cases when an ethernet header is present is the
packet.
On Mon, 25 Nov 2019 16:32:34 +0530, Martin Varghese wrote:
> > > Changes in v2:
> > > - check for dev type removed while updating ethertype
> > > in function skb_mpls_pop.
> > > - key->mac_proto is checked in function pop_mpls to pass
> > > ethernt flag to skb_mpls_pop.
> > > - dev type is checked in function tcf_mpls_act to pass
> > > ethernet flag to skb_mpls_pop.
> >
> > nit: changelog can be kept in the commit message for netdev patches
> >
> Multiple versions are mostly due to coding error.do you insist to keep
> the change log in commit message ?
Not really, just a minor suggestion.
Powered by blists - more mailing lists