netdev - Re: WARNING in sk_stream_kill

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20191125093956.58133ee8@cakuba.hsd1.ca.comcast.net>
Date:   Mon, 25 Nov 2019 09:39:56 -0800
From:   Jakub Kicinski <jakub.kicinski@...ronome.com>
To:     syzbot <syzbot+13e1ee9caeab5a9abc62@...kaller.appspotmail.com>
Cc:     aviadye@...lanox.com, borisp@...lanox.com, davejwatson@...com,
        davem@...emloft.net, gregkh@...uxfoundation.org,
        ilyal@...lanox.com, kstewart@...uxfoundation.org,
        linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
        pombredanne@...b.com, syzkaller-bugs@...glegroups.com,
        tglx@...utronix.de
Subject: Re: WARNING in sk_stream_kill_queues (3)

On Mon, 25 Nov 2019 07:59:01 -0800, syzbot wrote:
> syzbot has bisected this bug to:
> 
> commit 3c4d7559159bfe1e3b94df3a657b2cda3a34e218
> Author: Dave Watson <davejwatson@...com>
> Date:   Wed Jun 14 18:37:39 2017 +0000
> 
>      tls: kernel TLS support
> 
> bisection log:  https://syzkaller.appspot.com/x/bisect.txt?x=127a8f22e00000
> start commit:   be779f03 Merge tag 'kbuild-v4.18-2' of git://git.kernel.or..
> git tree:       upstream
> final crash:    https://syzkaller.appspot.com/x/report.txt?x=117a8f22e00000
> console output: https://syzkaller.appspot.com/x/log.txt?x=167a8f22e00000
> kernel config:  https://syzkaller.appspot.com/x/.config?x=855fb54e1e019da2
> dashboard link: https://syzkaller.appspot.com/bug?extid=13e1ee9caeab5a9abc62
> syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=165a0c1f800000
> C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=114591af800000
> 
> Reported-by: syzbot+13e1ee9caeab5a9abc62@...kaller.appspotmail.com
> Fixes: 3c4d7559159b ("tls: kernel TLS support")
> 
> For information about bisection process see: https://goo.gl/tpsmEJ#bisection

Looking at the repro timeline I'm fairly confident that
commit 9354544cbccf ("net/tls: fix page double free on TX cleanup")
stopped this. Even though it must had been appearing earlier due to a
different bug, because what the mentioned commit fixed was more recent
than the report.

#syz fix: net/tls: fix page double free on TX cleanup