netdev - Re: [PATCH v2] macvlan: schedule bc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20191125.105501.735127676571709693.davem@davemloft.net>
Date:   Mon, 25 Nov 2019 10:55:01 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     dong.menglong@....com.cn
Cc:     petrm@...lanox.com, jiri@...lanox.com, gustavo@...eddedor.com,
        liuhangbin@...il.com, ap420073@...il.com, jwi@...ux.ibm.com,
        mcroce@...hat.com, tglx@...utronix.de, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, xue.zhihong@....com.cn,
        wang.yi59@....com.cn, jiang.xuexin@....com.cn
Subject: Re: [PATCH v2] macvlan: schedule bc_work even if error

From: Menglong Dong <dong.menglong@....com.cn>
Date: Mon, 25 Nov 2019 16:58:09 +0800

> While enqueueing a broadcast skb to port->bc_queue, schedule_work()
> is called to add port->bc_work, which processes the skbs in
> bc_queue, to "events" work queue. If port->bc_queue is full, the
> skb will be discarded and schedule_work(&port->bc_work) won't be
> called. However, if port->bc_queue is full and port->bc_work is not
> running or pending, port->bc_queue will keep full and schedule_work()
> won't be called any more, and all broadcast skbs to macvlan will be
> discarded. This case can happen:
> 
> macvlan_process_broadcast() is the pending function of port->bc_work,
> it moves all the skbs in port->bc_queue to the queue "list", and
> processes the skbs in "list". During this, new skbs will keep being
> added to port->bc_queue in macvlan_broadcast_enqueue(), and
> port->bc_queue may already full when macvlan_process_broadcast()
> return. This may happen, especially when there are a lot of real-time
> threads and the process is preempted.
> 
> Fix this by calling schedule_work(&port->bc_work) even if
> port->bc_work is full in macvlan_broadcast_enqueue().
> 
> Fixes: 412ca1550cbe ("macvlan: Move broadcasts into a work queue")
> Signed-off-by: Menglong Dong <dong.menglong@....com.cn>

Applied and queued up for -stable, thanks.