netdev - Re: [PATCH] slip: Fix use-after-free Read in slip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20191125.110358.1439071254106161440.davem@davemloft.net>
Date:   Mon, 25 Nov 2019 11:03:58 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     jouni.hogander@...kie.com
Cc:     netdev@...r.kernel.org, socketcan@...tkopp.net,
        lukas.bulwahn@...il.com
Subject: Re: [PATCH] slip: Fix use-after-free Read in slip_open

From: jouni.hogander@...kie.com
Date: Mon, 25 Nov 2019 14:23:43 +0200

> From: Jouni Hogander <jouni.hogander@...kie.com>
> 
> Slip_open doesn't clean-up device which registration failed from the
> slip_devs device list. On next open after failure this list is iterated
> and freed device is accessed. Fix this by calling sl_free_netdev in error
> path.
> 
> Here is the trace from the Syzbot:
 ...
> Fixes: 3b5a39979daf ("slip: Fix memory leak in slip_open error path")
> Reported-by: syzbot+4d5170758f3762109542@...kaller.appspotmail.com
> Cc: David Miller <davem@...emloft.net>
> Cc: Oliver Hartkopp <socketcan@...tkopp.net>
> Cc: Lukas Bulwahn <lukas.bulwahn@...il.com>
> Signed-off-by: Jouni Hogander <jouni.hogander@...kie.com>

Applied and queued up for -stable.