netdev - Re: [PATCH 07/19] mm/gup: introduce pin_user_pages*() and FOLL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3989f406-c333-59f8-027a-e3506af59028@nvidia.com>
Date:   Mon, 25 Nov 2019 12:13:55 -0800
From:   John Hubbard <jhubbard@...dia.com>
To:     kbuild test robot <lkp@...el.com>
CC:     <kbuild-all@...ts.01.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Michal Hocko <mhocko@...e.com>, Jan Kara <jack@...e.cz>,
        <kvm@...r.kernel.org>, <linux-doc@...r.kernel.org>,
        David Airlie <airlied@...ux.ie>,
        Dave Chinner <david@...morbit.com>,
        <dri-devel@...ts.freedesktop.org>,
        LKML <linux-kernel@...r.kernel.org>, <linux-mm@...ck.org>,
        Paul Mackerras <paulus@...ba.org>,
        <linux-kselftest@...r.kernel.org>, Ira Weiny <ira.weiny@...el.com>,
        Jonathan Corbet <corbet@....net>, <linux-rdma@...r.kernel.org>,
        Michael Ellerman <mpe@...erman.id.au>,
        Mike Rapoport <rppt@...ux.ibm.com>,
        Christoph Hellwig <hch@...radead.org>,
        Jason Gunthorpe <jgg@...pe.ca>,
        Vlastimil Babka <vbabka@...e.cz>,
        Björn Töpel <bjorn.topel@...el.com>,
        <linux-media@...r.kernel.org>, Shuah Khan <shuah@...nel.org>,
        <linux-block@...r.kernel.org>,
        Jérôme Glisse <jglisse@...hat.com>,
        Al Viro <viro@...iv.linux.org.uk>,
        Dan Williams <dan.j.williams@...el.com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Magnus Karlsson <magnus.karlsson@...el.com>,
        Jens Axboe <axboe@...nel.dk>, <netdev@...r.kernel.org>,
        Alex Williamson <alex.williamson@...hat.com>,
        <linux-fsdevel@...r.kernel.org>, <bpf@...r.kernel.org>,
        <linuxppc-dev@...ts.ozlabs.org>,
        "David S . Miller" <davem@...emloft.net>,
        Mike Kravetz <mike.kravetz@...cle.com>
Subject: Re: [PATCH 07/19] mm/gup: introduce pin_user_pages*() and FOLL_PIN

On 11/25/19 12:44 AM, kbuild test robot wrote:
> Hi John,
> 
> Thank you for the patch! Yet something to improve:
> 
> [auto build test ERROR on rdma/for-next]
> [cannot apply to v5.4 next-20191122]
> [if your patch is applied to the wrong git tree, please drop us a note to help
> improve the system. BTW, we also suggest to use '--base' option to specify the
> base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
> 
> url:    https://github.com/0day-ci/linux/commits/John-Hubbard/pin_user_pages-reduced-risk-series-for-Linux-5-5/20191125-125637
> base:   https://git.kernel.org/pub/scm/linux/kernel/git/rdma/rdma.git for-next
> config: arm-randconfig-a001-20191125 (attached as .config)
> compiler: arm-linux-gnueabi-gcc (GCC) 7.4.0
> reproduce:
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # save the attached .config to linux build tree
>         GCC_VERSION=7.4.0 make.cross ARCH=arm 
> 
> If you fix the issue, kindly add following tag
> Reported-by: kbuild test robot <lkp@...el.com>
> 
> All errors (new ones prefixed by >>):
> 
>    mm/gup.o: In function `pin_user_pages_remote':
>>> mm/gup.c:2528: undefined reference to `get_user_pages_remote'
> 
> vim +2528 mm/gup.c


This, and the other (sh) report, is due to !CONFIG_MMU lacking a get_user_pages_remote(), 
but pin_user_pages_remote() needs it for a (temporary) implementation. I'll post the fix, 
in v2.


thanks,
-- 
John Hubbard
NVIDIA