netdev - Re: [PATCH net] ipv6: set lwtstate for ns and na dst

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20191125.145336.1803100409578989775.davem@davemloft.net>
Date:   Mon, 25 Nov 2019 14:53:36 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     lucien.xin@...il.com
Cc:     netdev@...r.kernel.org, dsahern@...il.com, jbenc@...hat.com,
        roopa@...ulusnetworks.com
Subject: Re: [PATCH net] ipv6: set lwtstate for ns and na dst

From: Xin Long <lucien.xin@...il.com>
Date: Mon, 25 Nov 2019 14:23:12 +0800

> This patch is to fix an issue that ipv6 ns and na can't go out with the
> correct tunnel info, and it can be reproduced by:

And why shouldn't RS and redirects get this treatment too?

And then, at that point, all callers of ndisc_send_skb() have this
early route lookup code (and thus the "!dst" code path is unused), and
the question ultimately becomes why doesn't ndisc_send_skb() itself
have the dst lookup modification?

I'm not too sure about this change and will not apply it.