netdev - Re: [PATCH] bpf: fix a no-mmu build failure by providing a stub allocator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <735f27ed-65dd-d132-e6b4-20ba5749876c@nvidia.com>
Date:   Mon, 25 Nov 2019 15:45:17 -0800
From:   John Hubbard <jhubbard@...dia.com>
To:     Daniel Borkmann <daniel@...earbox.net>,
        Andrii Nakryiko <andriin@...com>
CC:     Song Liu <songliubraving@...com>,
        John Fastabend <john.fastabend@...il.com>,
        Johannes Weiner <hannes@...xchg.org>,
        Linux Next Mailing List <linux-next@...r.kernel.org>,
        <bpf@...r.kernel.org>, <netdev@...r.kernel.org>,
        <linux-mm@...ck.org>, LKML <linux-kernel@...r.kernel.org>,
        kbuild test robot <lkp@...el.com>
Subject: Re: [PATCH] bpf: fix a no-mmu build failure by providing a stub
 allocator

On 11/25/19 3:43 PM, Daniel Borkmann wrote:
> On 11/26/19 12:41 AM, John Hubbard wrote:
>> Commit fc9702273e2e ("bpf: Add mmap() support for BPF_MAP_TYPE_ARRAY")
>> added code that calls vmalloc_user_node_flags() and therefore requires
>> mm/vmalloc.c. However, that file is not built for the !CONFIG_MMU case.
>> This leads to a build failure when using ARM with the config provided
>> by at least one particular kbuild test robot report [1].
>>
>> [1] https://lore/kernel.org/r/201911251639.UWS3hE3Y%lkp@intel.com
>>
>> Fix the build by providing a stub function for __bpf_map_area_alloc().
>>
>> Fixes: fc9702273e2e ("bpf: Add mmap() support for BPF_MAP_TYPE_ARRAY")
>> Reported-by: kbuild test robot <lkp@...el.com>
>> Cc: Andrii Nakryiko <andriin@...com>
>> Cc: Daniel Borkmann <daniel@...earbox.net>
>> Cc: Song Liu <songliubraving@...com>
>> Cc: John Fastabend <john.fastabend@...il.com>
>> Cc: Johannes Weiner <hannes@...xchg.org>
>> Signed-off-by: John Hubbard <jhubbard@...dia.com>
> 
> Thanks for the patch, already fixed via:
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git/commit/?id=ed81745a4c96841937f1da35c0eb66ac312e1480

OK, good, that's a better fix, too. Appreciate the quick answers!


thanks,
-- 
John Hubbard
NVIDIA