netdev - Re: [PATCH net v2 0/4] ibmvnic: Harden device commands and queries

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20191126.131945.1705488455872187863.davem@davemloft.net>
Date:   Tue, 26 Nov 2019 13:19:45 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     tlfalcon@...ux.ibm.com
Cc:     jakub.kicinski@...ronome.com, netdev@...r.kernel.org,
        linuxppc-dev@...abs.org, dnbanerg@...ibm.com,
        brking@...ux.vnet.ibm.com, julietk@...ux.vnet.ibm.com
Subject: Re: [PATCH net v2 0/4] ibmvnic: Harden device commands and queries

From: Thomas Falcon <tlfalcon@...ux.ibm.com>
Date: Mon, 25 Nov 2019 17:12:52 -0600

> This patch series fixes some shortcomings with the current
> VNIC device command implementation. The first patch fixes
> the initialization of driver completion structures used
> for device commands. Additionally, all waits for device
> commands are bounded with a timeout in the event that the
> device does not respond or becomes inoperable. Finally,
> serialize queries to retain the integrity of device return
> codes.
> 
> Changes in v2:
> 
>  - included header comment for ibmvnic_wait_for_completion
>  - removed open-coded loop in patch 3/4, suggested by Jakub
>  - ibmvnic_wait_for_completion accepts timeout value in milliseconds
>    instead of jiffies
>  - timeout calculations cleaned up and completed before wait loop
>  - included missing mutex_destroy calls, suggested by Jakub
>  - included comment before mutex declaration

Series applied, thanks.