netdev - Re: [PATCH] net: mscc: ocelot: fix potential issues accessing skbs list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20191126.140155.381506426353243938.davem@davemloft.net>
Date:   Tue, 26 Nov 2019 14:01:55 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     yangbo.lu@....com
Cc:     netdev@...r.kernel.org, alexandre.belloni@...tlin.com,
        UNGLinuxDriver@...rochip.com
Subject: Re: [PATCH] net: mscc: ocelot: fix potential issues accessing skbs
 list

From: Yangbo Lu <yangbo.lu@....com>
Date: Tue, 26 Nov 2019 18:44:03 +0800

> Fix two prtential issues accessing skbs list.
> - Protect skbs list in case of competing for accessing.
> - Break the matching loop when find the matching skb to
>   avoid consuming more skbs incorrectly. The ID is only
>   from 0 to 3, but the FIFO supports 128 timestamps at most.
> 
> Signed-off-by: Yangbo Lu <yangbo.lu@....com>

Seriously, use skb_queue_head and associated helpers, we have
all of the infrastructure and arrangements for this.