netdev - Re: [PATCH net] gve: Fix the queue page list allocated pages count

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20191126.140543.12960644904577654.davem@davemloft.net>
Date:   Tue, 26 Nov 2019 14:05:43 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     jeroendb@...gle.com
Cc:     netdev@...r.kernel.org, csully@...gle.com
Subject: Re: [PATCH net] gve: Fix the queue page list allocated pages count

From: Jeroen de Borst <jeroendb@...gle.com>
Date: Tue, 26 Nov 2019 09:33:13 -0800

> In gve_alloc_queue_page_list(), when a page allocation fails,
> qpl->num_entries will be wrong.  In this case priv->num_registered_pages
> can underflow in gve_free_queue_page_list(), causing subsequent calls
> to gve_alloc_queue_page_list() to fail.
> 
> Signed-off-by: Jeroen de Borst <jeroendb@...gle.com>
> Reviewed-by: Catherine Sullivan <csully@...gle.com>

You need to add an appropriate Fixes: tag.

Please take care of this and resubmit, thank you.