netdev - Re: [PATCH net] net: dsa: silence a static checker warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20191126.151753.744862410233394124.davem@davemloft.net>
Date:   Tue, 26 Nov 2019 15:17:53 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     dan.carpenter@...cle.com
Cc:     andrew@...n.ch, olteanv@...il.com, vivien.didelot@...il.com,
        f.fainelli@...il.com, netdev@...r.kernel.org,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH net] net: dsa: silence a static checker warning

From: Dan Carpenter <dan.carpenter@...cle.com>
Date: Tue, 26 Nov 2019 15:18:54 +0300

> This code is harmless but it triggers a Smatch static checker warning:
> 
>     net/dsa/tag_8021q.c:108 dsa_8021q_restore_pvid()
>     error: uninitialized symbol 'pvid'.
> 
> I believe that UBSan will complain at run time as well.  The solution is
> to just re-order the conditions.
> 
> Fixes: c80ed84e7688 ("net: dsa: tag_8021q: Fix dsa_8021q_restore_pvid for an absent pvid")
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>

THis doesn't apply to the current net tree.