netdev - Re: [PATCH net-next v2 13/13] bnxt_en: Add support for flashing the device via devlink

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAACQVJqpT8aYdQZGzg=9iv=wejZN3AKbMDACv4RF8uFinkEuwQ@mail.gmail.com>
Date:   Tue, 26 Nov 2019 09:22:13 +0530
From:   Vasundhara Volam <vasundhara-v.volam@...adcom.com>
To:     Jiri Pirko <jiri@...nulli.us>
Cc:     Michael Chan <michael.chan@...adcom.com>,
        David Miller <davem@...emloft.net>,
        Jakub Kicinski <jakub.kicinski@...ronome.com>,
        Netdev <netdev@...r.kernel.org>, Jiri Pirko <jiri@...lanox.com>
Subject: Re: [PATCH net-next v2 13/13] bnxt_en: Add support for flashing the
 device via devlink

On Mon, Nov 25, 2019 at 3:50 PM Jiri Pirko <jiri@...nulli.us> wrote:
>
> Sun, Nov 24, 2019 at 04:30:50AM CET, michael.chan@...adcom.com wrote:
> >From: Vasundhara Volam <vasundhara-v.volam@...adcom.com>
> >
> >Use the same bnxt_flash_package_from_file() function to support
> >devlink flash operation.
> >
> >Cc: Jiri Pirko <jiri@...lanox.com>
> >Signed-off-by: Vasundhara Volam <vasundhara-v.volam@...adcom.com>
> >Signed-off-by: Michael Chan <michael.chan@...adcom.com>
> >---
> > drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c | 20 ++++++++++++++++++++
> > drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c |  4 ++--
> > drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.h |  2 ++
> > 3 files changed, 24 insertions(+), 2 deletions(-)
> >
> >diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c
> >index 7078271..acb2dd6 100644
> >--- a/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c
> >+++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c
> >@@ -14,6 +14,25 @@
> > #include "bnxt.h"
> > #include "bnxt_vfr.h"
> > #include "bnxt_devlink.h"
> >+#include "bnxt_ethtool.h"
> >+
> >+static int
> >+bnxt_dl_flash_update(struct devlink *dl, const char *filename,
> >+                   const char *region, struct netlink_ext_ack *extack)
> >+{
> >+      struct bnxt *bp = bnxt_get_bp_from_dl(dl);
> >+
> >+      if (region)
> >+              return -EOPNOTSUPP;
> >+
> >+      if (!BNXT_PF(bp)) {
> >+              NL_SET_ERR_MSG_MOD(extack,
> >+                                 "flash update not supported from a VF");
> >+              return -EPERM;
> >+      }
> >+
> >+      return bnxt_flash_package_from_file(bp->dev, filename, 0);
> >+}
> >
> > static int bnxt_fw_reporter_diagnose(struct devlink_health_reporter *reporter,
> >                                    struct devlink_fmsg *fmsg,
> >@@ -225,6 +244,7 @@ static const struct devlink_ops bnxt_dl_ops = {
> >       .eswitch_mode_set = bnxt_dl_eswitch_mode_set,
> >       .eswitch_mode_get = bnxt_dl_eswitch_mode_get,
> > #endif /* CONFIG_BNXT_SRIOV */
> >+      .flash_update     = bnxt_dl_flash_update,
>
> Could you please consider implementing flash status notifications?
> See:
> devlink_flash_update_begin_notify()
> devlink_flash_update_end_notify()
> devlink_flash_update_status_notify()
>
>
> Thanks!
Sure. Thanks.
>
>
> > };
> >
> > enum bnxt_dl_param_id {
> >diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c
> >index e455aaa..2ccf79c 100644
> >--- a/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c
> >+++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c
> >@@ -2000,8 +2000,8 @@ static int bnxt_flash_firmware_from_file(struct net_device *dev,
> >       return rc;
> > }
> >
> >-static int bnxt_flash_package_from_file(struct net_device *dev,
> >-                                      char *filename, u32 install_type)
> >+int bnxt_flash_package_from_file(struct net_device *dev, const char *filename,
> >+                               u32 install_type)
> > {
> >       struct bnxt *bp = netdev_priv(dev);
> >       struct hwrm_nvm_install_update_output *resp = bp->hwrm_cmd_resp_addr;
> >diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.h b/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.h
> >index 01de7e7..4428d0a 100644
> >--- a/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.h
> >+++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.h
> >@@ -81,6 +81,8 @@ extern const struct ethtool_ops bnxt_ethtool_ops;
> > u32 _bnxt_fw_to_ethtool_adv_spds(u16, u8);
> > u32 bnxt_fw_to_ethtool_speed(u16);
> > u16 bnxt_get_fw_auto_link_speeds(u32);
> >+int bnxt_flash_package_from_file(struct net_device *dev, const char *filename,
> >+                               u32 install_type);
> > void bnxt_ethtool_init(struct bnxt *bp);
> > void bnxt_ethtool_free(struct bnxt *bp);
> >
> >--
> >2.5.1
> >