netdev - [v2, 0/2] net: mscc: ocelot: fix potential issues accessing skbs list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20191127072757.34502-1-yangbo.lu@nxp.com>
Date:   Wed, 27 Nov 2019 15:27:55 +0800
From:   Yangbo Lu <yangbo.lu@....com>
To:     netdev@...r.kernel.org,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Microchip Linux Driver Support <UNGLinuxDriver@...rochip.com>,
        "David S . Miller" <davem@...emloft.net>,
        Vladimir Oltean <vladimir.oltean@....com>
Cc:     Yangbo Lu <yangbo.lu@....com>
Subject: [v2, 0/2] net: mscc: ocelot: fix potential issues accessing skbs list

Fix two prtential issues accessing skbs list.
- Break the matching loop when find the matching skb to avoid
  consuming more skbs incorrectly. The timestamp ID is only
  from 0 to 3 while the FIFO supports 128 timestamps at most.
- Convert to use skb queue instead of the list of skbs to provide
  protect with lock.

---
Changes for v2:
	- Split into two patches.
	- Converted to use skb queue.

Yangbo Lu (2):
  net: mscc: ocelot: avoid incorrect consuming in skbs list
  net: mscc: ocelot: use skb queue instead of skbs list

 drivers/net/ethernet/mscc/ocelot.c | 55 +++++++++++++-------------------------
 include/soc/mscc/ocelot.h          |  9 +------
 2 files changed, 20 insertions(+), 44 deletions(-)

-- 
2.7.4