netdev - Re: [PATCH net] net: wireless: intel: iwlwifi: fix GRO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <PSXP216MB04382F0BA8CE3754439EA2CC80440@PSXP216MB0438.KORP216.PROD.OUTLOOK.COM>
Date:   Wed, 27 Nov 2019 11:16:21 +0000
From:   Nicholas Johnson <nicholas.johnson-opensource@...look.com.au>
To:     Alexander Lobakin <alobakin@...nk.ru>
CC:     Luciano Coelho <luciano.coelho@...el.com>,
        "David S. Miller" <davem@...emloft.net>,
        Edward Cree <ecree@...arflare.com>,
        Jiri Pirko <jiri@...lanox.com>,
        Eric Dumazet <edumazet@...gle.com>,
        Ido Schimmel <idosch@...lanox.com>,
        Paolo Abeni <pabeni@...hat.com>,
        Petr Machata <petrm@...lanox.com>,
        Sabrina Dubroca <sd@...asysnail.net>,
        Florian Fainelli <f.fainelli@...il.com>,
        Jassi Brar <jaswinder.singh@...aro.org>,
        Manish Chopra <manishc@...vell.com>,
        "GR-Linux-NIC-Dev@...vell.com" <GR-Linux-NIC-Dev@...vell.com>,
        Johannes Berg <johannes.berg@...el.com>,
        Emmanuel Grumbach <emmanuel.grumbach@...el.com>,
        Intel Linux Wireless <linuxwifi@...el.com>,
        Kalle Valo <kvalo@...eaurora.org>,
        "Kenneth R. Crudup" <kenny@...ix.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net] net: wireless: intel: iwlwifi: fix GRO_NORMAL packet
 stalling

On Wed, Nov 27, 2019 at 01:29:03PM +0300, Alexander Lobakin wrote:
> Nicholas Johnson wrote 27.11.2019 13:23:
> > Hi,
> 
> Hi Nicholas,
> 
> >  Sorry for top down reply, stuck with my phone. If it replies HTML
> > then I am so done with Outlook client.

I am very sorry to everybody for the improper reply. It looks like it 
was HTML as vger.kernel.org told me I was spam. If anybody knows a good 
email client for kernel development for Android then I am all ears.

I went home early and I have my computer(s) now.

> > 
> >  Does my Reported-by tag apply here?
> > 
> >  As the reporter, should I check to see that it indeed solves the
> > issue on the original hardware setup? I can do this within two hours
> > and give Tested-by then.
> 
> Oops, I'm sorry I forgot to mention you in the commit message. Let's
> see what Dave will say, I have no problems with waiting for your test
> results and publishing v2.

All good. :)

I tested the the patch and it works fine. Great work, the first 
hypothesis as to what the problem was is correct. It now connects to 
wireless networks without any hassles.

Reported-by: Nicholas Johnson <nicholas.johnson-opensource@...look.com.au>
Tested-by: Nicholas Johnson <nicholas.johnson-opensource@...look.com.au>

I do not understand the networking subsystem well enough to give 
Reviewed-by, yet. Hopefully in time.

Thanks to everybody for handling my report.

> 
> >  Thanks
> > 
> >  Regards,
> > 
> >  Nicholas
> 
> Regards,
> ᚷ ᛖ ᚢ ᚦ ᚠ ᚱ

Regards,
Nicholas