netdev - Re: [PATCH v2 net] net: mscc: ocelot: unregister the PTP clock on deinit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20191128.231314.78069224750097408.davem@davemloft.net>
Date:   Thu, 28 Nov 2019 23:13:14 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     olteanv@...il.com
Cc:     richardcochran@...il.com, andrew@...n.ch, f.fainelli@...il.com,
        vivien.didelot@...il.com, claudiu.manoil@....com,
        alexandru.marginean@....com, xiaoliang.yang_1@....com,
        yangbo.lu@....com, netdev@...r.kernel.org,
        alexandre.belloni@...tlin.com, UNGLinuxDriver@...rochip.com,
        vladimir.oltean@....com, antoine.tenart@...tlin.com
Subject: Re: [PATCH v2 net] net: mscc: ocelot: unregister the PTP clock on
 deinit

From: Vladimir Oltean <olteanv@...il.com>
Date: Thu, 28 Nov 2019 13:23:42 +0200

> +static void ocelot_deinit_timestamp(struct ocelot *ocelot)
> +{
> +	if (ocelot->ptp_clock)
> +		ptp_clock_unregister(ocelot->ptp_clock);
> +}

No need for a helper function, you're calling this in only _one_ place.