netdev - Re: [PATCH v3 net-next 2/2] Special handling for IP & MPLS.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 29 Nov 2019 13:20:37 -0500
From:   Willem de Bruijn <willemdebruijn.kernel@...il.com>
To:     Martin Varghese <martinvarghesenokia@...il.com>
Cc:     Willem de Bruijn <willemdebruijn.kernel@...il.com>,
        Network Development <netdev@...r.kernel.org>,
        David Miller <davem@...emloft.net>, corbet@....net,
        Alexey Kuznetsov <kuznet@....inr.ac.ru>,
        Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>,
        scott.drennan@...ia.com, Jiri Benc <jbenc@...hat.com>,
        martin.varghese@...ia.com
Subject: Re: [PATCH v3 net-next 2/2] Special handling for IP & MPLS.

On Thu, Nov 28, 2019 at 11:13 AM Martin Varghese
<martinvarghesenokia@...il.com> wrote:
>
> On Mon, Nov 18, 2019 at 12:30:11PM -0500, Willem de Bruijn wrote:
> > On Sat, Nov 16, 2019 at 12:45 AM Martin Varghese
> > <martinvarghesenokia@...il.com> wrote:
> > >
> > > From: Martin Varghese <martin.varghese@...ia.com>
> > >
> > > Special handling is needed in bareudp module for IP & MPLS as they support
> > > more than one ethertypes.
> > >
> > > MPLS has 2 ethertypes. 0x8847 for MPLS unicast and 0x8848 for MPLS multicast.
> > > While decapsulating MPLS packet from UDP packet the tunnel destination IP
> > > address is checked to determine the ethertype. The ethertype of the packet
> > > will be set to 0x8848 if the  tunnel destination IP address is a multicast
> > > IP address. The ethertype of the packet will be set to 0x8847 if the
> > > tunnel destination IP address is a unicast IP address.
> > >
> > > IP has 2 ethertypes.0x0800 for IPV4 and 0x86dd for IPv6. The version field
> > > of the IP header tunnelled will be checked to determine the ethertype.
> >
> > If using ipv6 dual stack, it might make more sense to use extended
> > mode with the ipv6 device instead of the ipv4 device.
> >
> ipv6 dual stack (v6 socket) is for the tunnel.the ethertype mentioned above
> is for the inner protocol being tunnelled
>
> > Also, the term extended mode is not self describing. Dual stack as
> > term would be, but is not relevant to MPLS. Maybe "dual_proto"?
> >
> multi_proto ?

Sounds good to me, thanks.