netdev - Re: unregister_netdevice: waiting for DEV to become free (2)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKXUXMwwxvJYjB0BkcmYg=AkzxW37SPiEuhyFPoATzEVY-MC7g@mail.gmail.com>
Date:   Fri, 29 Nov 2019 06:54:47 +0100
From:   Lukas Bulwahn <lukas.bulwahn@...il.com>
To:     Tetsuo Handa <penguin-kernel@...ove.sakura.ne.jp>
Cc:     syzbot <syzbot+30209ea299c09d8785c9@...kaller.appspotmail.com>,
        YueHaibing <yuehaibing@...wei.com>,
        Jouni Hogander <jouni.hogander@...kie.com>,
        Julian Anastasov <ja@....bg>, ddstreet@...e.org,
        Dmitry Vyukov <dvyukov@...gle.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Netdev <netdev@...r.kernel.org>, syzkaller-bugs@...glegroups.com,
        Hulk Robot <hulkci@...wei.com>,
        "David S. Miller" <davem@...emloft.net>
Subject: Re: unregister_netdevice: waiting for DEV to become free (2)

On Thu, Nov 28, 2019 at 10:56 AM Tetsuo Handa
<penguin-kernel@...ove.sakura.ne.jp> wrote:
>
> Hello people involved in commit a3e23f719f5c4a38 ("net-sysfs: call dev_hold if kobject_init_and_add success")
> and commit b8eb718348b8fb30 ("net-sysfs: Fix reference count leak in rx|netdev_queue_add_kobject").
>
> syzbot is reporting that unregister_netdevice() hangs due to underflowing
> device refcount when kobject_init_and_add() failed due to -ENOMEM.
>

Tetsuo, would you happen to have a C reproducer program that creates
the trace you reported?

I could not quickly find one that by the date would fit to when we
included our change on this syzbot page:
https://syzkaller.appspot.com/bug?id=bae9a2236bfede42cf3d219e6bf6740c583568a4

Jouni, can you please follow up on this report.

Thanks.

Lukas