netdev - Re: [PATCH v1] net: WireGuard secure network tunnel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20191128.222735.1430087391284485253.davem@davemloft.net>
Date:   Thu, 28 Nov 2019 22:27:35 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     Jason@...c4.com
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        gregkh@...uxfoundation.org, torvalds@...ux-foundation.org,
        herbert@...dor.apana.org.au, linux-crypto@...r.kernel.org
Subject: Re: [PATCH v1] net: WireGuard secure network tunnel

From: "Jason A. Donenfeld" <Jason@...c4.com>
Date: Fri, 29 Nov 2019 04:32:05 +0100

> I'm not a huge fan of doing manual skb surgery either. The annoying
> thing here is that skb_gso_segment returns a list of skbs that's
> terminated by the last one's next pointer being NULL. I assume it's this
> way so that the GSO code doesn't have to pass a head around.

Sorry, I missed that this was processing a GSO list which doesn't use
double linked list semantics.

So ignore my feedback on this one :-)