netdev - Re: [PATCH nf] netfilter: nf_queue: enqueue skbs with NULL dst

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAGnkfhzTq2HJ2Pm1sLOLaeOET926SjqRznQLy-CrMue_cpeLRg@mail.gmail.com>
Date:   Mon, 2 Dec 2019 22:51:35 +0100
From:   Matteo Croce <mcroce@...hat.com>
To:     Marco Oliverio <marco.oliverio@...aza.com>
Cc:     rocco.folino@...aza.com, netdev <netdev@...r.kernel.org>,
        Florian Westphal <fw@...len.de>
Subject: Re: [PATCH nf] netfilter: nf_queue: enqueue skbs with NULL dst

On Mon, Dec 2, 2019 at 7:43 PM Marco Oliverio <marco.oliverio@...aza.com> wrote:
>
> Bridge packets that are forwarded have skb->dst == NULL and get
> dropped by the check introduced by
> b60a77386b1d4868f72f6353d35dabe5fbe981f2 (net: make skb_dst_force
> return true when dst is refcounted).
>
> To fix this we check skb_dst() before skb_dst_force(), so we don't
> drop skb packet with dst == NULL. This holds also for skb at the
> PRE_ROUTING hook so we remove the second check.
>
> Fixes: b60a773 ("net: make skb_dst_forcereturn true when dst is refcounted")
>
> Signed-off-by: Marco Oliverio <marco.oliverio@...aza.com>
> Signed-off-by: Rocco Folino <rocco.folino@...aza.com>

Tested-by: Matteo Croce <mcroce@...hat.com>

-- 
Matteo Croce
per aspera ad upstream