lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 2 Dec 2019 22:51:57 +0000 From: Leo Li <leoyang.li@....com> To: David Miller <davem@...emloft.net> CC: "linuxppc-dev@...ts.ozlabs.org" <linuxppc-dev@...ts.ozlabs.org>, "linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, Scott Wood <oss@...error.net>, Timur Tabi <timur@...nel.org>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>, Rasmus Villemoes <linux@...musvillemoes.dk>, Qiang Zhao <qiang.zhao@....com>, Christophe Leroy <christophe.leroy@....fr> Subject: RE: [PATCH v6 44/49] net/wan/fsl_ucc_hdlc: avoid use of IS_ERR_VALUE() > -----Original Message----- > From: Rasmus Villemoes <linux@...musvillemoes.dk> > Sent: Thursday, November 28, 2019 8:56 AM > To: Qiang Zhao <qiang.zhao@....com>; Leo Li <leoyang.li@....com>; > Christophe Leroy <christophe.leroy@....fr> > Cc: linuxppc-dev@...ts.ozlabs.org; linux-arm-kernel@...ts.infradead.org; > linux-kernel@...r.kernel.org; Scott Wood <oss@...error.net>; Timur Tabi > <timur@...nel.org>; Rasmus Villemoes <linux@...musvillemoes.dk>; > netdev@...r.kernel.org > Subject: [PATCH v6 44/49] net/wan/fsl_ucc_hdlc: avoid use of > IS_ERR_VALUE() Hi David, Would you help to review patch 44-47 in the series? If it is fine with you, I can take these 4 patches with the whole series though soc tree to enable the QE drivers on ARM and PPC64 with your ACK. Thanks, Leo > > When building this on a 64-bit platform gcc rightly warns that the error > checking is broken (-ENOMEM stored in an u32 does not compare greater > than (unsigned long)-MAX_ERRNO). Instead, now that > qe_muram_alloc() returns s32, use that type to store the return value and > use standard kernel style "ret < 0". > > Reviewed-by: Timur Tabi <timur@...nel.org> > Signed-off-by: Rasmus Villemoes <linux@...musvillemoes.dk>
Powered by blists - more mailing lists