lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 2 Dec 2019 10:37:52 +0100 From: Daniel Borkmann <daniel@...earbox.net> To: Michael Ellerman <mpe@...erman.id.au> Cc: Aurelien Jarno <aurelien@...el32.net>, linux-kernel@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org, debian-kernel@...ts.debian.org, Alexei Starovoitov <ast@...nel.org>, Martin KaFai Lau <kafai@...com>, Song Liu <songliubraving@...com>, Yonghong Song <yhs@...com>, Andrii Nakryiko <andriin@...com>, "open list:BPF (Safe dynamic programs and tools)" <netdev@...r.kernel.org>, "open list:BPF (Safe dynamic programs and tools)" <bpf@...r.kernel.org> Subject: Re: [PATCH] libbpf: fix readelf output parsing on powerpc with recent binutils On Mon, Dec 02, 2019 at 04:53:26PM +1100, Michael Ellerman wrote: > Aurelien Jarno <aurelien@...el32.net> writes: > > On powerpc with recent versions of binutils, readelf outputs an extra > > field when dumping the symbols of an object file. For example: > > > > 35: 0000000000000838 96 FUNC LOCAL DEFAULT [<localentry>: 8] 1 btf_is_struct > > > > The extra "[<localentry>: 8]" prevents the GLOBAL_SYM_COUNT variable to > > be computed correctly and causes the checkabi target to fail. > > > > Fix that by looking for the symbol name in the last field instead of the > > 8th one. This way it should also cope with future extra fields. > > > > Signed-off-by: Aurelien Jarno <aurelien@...el32.net> > > --- > > tools/lib/bpf/Makefile | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > Thanks for fixing that, it's been on my very long list of test failures > for a while. > > Tested-by: Michael Ellerman <mpe@...erman.id.au> Looks good & also continues to work on x86. Applied, thanks!
Powered by blists - more mailing lists