lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 2 Dec 2019 11:19:00 -0600 From: Tom Lendacky <thomas.lendacky@....com> To: Sebastian Andrzej Siewior <bigeasy@...utronix.de>, netdev@...r.kernel.org Cc: "David S. Miller" <davem@...emloft.net>, Thomas Gleixner <tglx@...utronix.de> Subject: Re: [PATCH net 1/2] amd-xgbe: Use __napi_schedule() in BH context On 11/26/19 4:20 PM, Sebastian Andrzej Siewior wrote: > The driver uses __napi_schedule_irqoff() which is fine as long as it is > invoked with disabled interrupts by everybody. Since the commit > mentioned below the driver may invoke xgbe_isr_task() in tasklet/softirq > context. This may lead to list corruption if another driver uses > __napi_schedule_irqoff() in IRQ context. > > Use __napi_schedule() which safe to use from IRQ and softirq context. > > Fixes: 85b85c853401d ("amd-xgbe: Re-issue interrupt if interrupt status not cleared") > Cc: Tom Lendacky <thomas.lendacky@....com> > Signed-off-by: Sebastian Andrzej Siewior <bigeasy@...utronix.de> Acked-by: Tom Lendacky <thomas.lendacky@....com> > --- > drivers/net/ethernet/amd/xgbe/xgbe-drv.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/amd/xgbe/xgbe-drv.c b/drivers/net/ethernet/amd/xgbe/xgbe-drv.c > index 98f8f20331544..3bd20f7651207 100644 > --- a/drivers/net/ethernet/amd/xgbe/xgbe-drv.c > +++ b/drivers/net/ethernet/amd/xgbe/xgbe-drv.c > @@ -514,7 +514,7 @@ static void xgbe_isr_task(unsigned long data) > xgbe_disable_rx_tx_ints(pdata); > > /* Turn on polling */ > - __napi_schedule_irqoff(&pdata->napi); > + __napi_schedule(&pdata->napi); > } > } else { > /* Don't clear Rx/Tx status if doing per channel DMA >
Powered by blists - more mailing lists