lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Tue, 03 Dec 2019 11:28:03 -0800 (PST)
From:   David Miller <>
Subject: Re: [PATCH v3 net] net: mscc: ocelot: unregister the PTP clock on

From: Vladimir Oltean <>
Date: Tue,  3 Dec 2019 17:45:35 +0200

> From: Vladimir Oltean <>
> Currently a switch driver deinit frees the regmaps, but the PTP clock is
> still out there, available to user space via /dev/ptpN. Any PTP
> operation is a ticking time bomb, since it will attempt to use the freed
> regmaps and thus trigger kernel panics:
> And now that ocelot->ptp_clock is checked at exit, prevent a potential
> error where ptp_clock_register returned a pointer-encoded error, which
> we are keeping in the ocelot private data structure. So now,
> ocelot->ptp_clock is now either NULL or a valid pointer.
> Fixes: 4e3b0468e6d7 ("net: mscc: PTP Hardware Clock (PHC) support")
> Cc: Antoine Tenart <>
> Reviewed-by: Florian Fainelli <>
> Signed-off-by: Vladimir Oltean <>

Applied and queued up for v5.4 -stable, thanks.

Powered by blists - more mailing lists