netdev - Re: [PATCH RFC v7 net-next] netdev: pass the stuck queue to the timeout handler

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 3 Dec 2019 11:47:44 -0800
From:   Shannon Nelson <snelson@...sando.io>
To:     "Michael S. Tsirkin" <mst@...hat.com>, jcfaracco@...il.com
Cc:     linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
        davem@...emloft.net, jasowang@...hat.com,
        virtualization@...ts.linux-foundation.org, dnmendes76@...il.com
Subject: Re: [PATCH RFC v7 net-next] netdev: pass the stuck queue to the
 timeout handler

On 12/2/19 11:12 PM, Michael S. Tsirkin wrote:
> This allows incrementing the correct timeout statistic without any mess.
> Down the road, devices can learn to reset just the specific queue.
>
[...]
> diff --git a/drivers/net/ethernet/pensando/ionic/ionic_lif.c b/drivers/net/ethernet/pensando/ionic/ionic_lif.c
> index 20faa8d24c9f..f7beb1b9e9d6 100644
> --- a/drivers/net/ethernet/pensando/ionic/ionic_lif.c
> +++ b/drivers/net/ethernet/pensando/ionic/ionic_lif.c
> @@ -1268,7 +1268,7 @@ static void ionic_tx_timeout_work(struct work_struct *ws)
>   	rtnl_unlock();
>   }
>   
> -static void ionic_tx_timeout(struct net_device *netdev)
> +static void ionic_tx_timeout(struct net_device *netdev, unsigned int txqueue)
>   {
>   	struct ionic_lif *lif = netdev_priv(netdev);
>   
>
[...]


For drivers/net/ethernet/pensando/ionic:
Acked-by: Shannon Nelson <snelson@...sando.io>