netdev - Re: [PATCH iproute2] ss: fix end-of-line printing in misc/ss.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191204111107.4a8d7115@hermes.lan>
Date:   Wed, 4 Dec 2019 11:11:07 -0800
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Brian Vazquez <brianvv@...gle.com>
Cc:     Brian Vazquez <brianvv.kernel@...il.com>,
        David Ahern <dsahern@...il.com>,
        Mahesh Bandewar <maheshb@...gle.com>,
        Maciej Zenczykowski <maze@...gle.com>, netdev@...r.kernel.org,
        Hritik Vijay <hritikxx8@...il.com>
Subject: Re: [PATCH iproute2] ss: fix end-of-line printing in misc/ss.c

On Tue, 26 Nov 2019 21:21:18 -0800
Brian Vazquez <brianvv@...gle.com> wrote:

> Before commit 5883c6eba517, function field_is_last() was incorrectly
> reporting which column was the last because it was missing COL_PROC
> and by purely coincidence it was correctly printing the end-of-line and
> moving to the first column since the very last field was empty, and
> end-of-line was added for the last non-empty token since it was seen as
> the last field.
> 
> This commits correcrly prints the end-of-line for the last entrien in
> the ss command.
> 
> Tested:
> diff <(./ss.old -nltp) <(misc/ss -nltp)
> 38c38
> < LISTEN    0   128     [::1]:35417   [::]:*   users:(("foo",pid=65254,fd=116))
> \ No newline at end of file
> ---
> > LISTEN    0   128     [::1]:35417   [::]:*   users:(("foo",pid=65254,fd=116))  
> 
> Cc: Hritik Vijay <hritikxx8@...il.com>
> Fixes: 5883c6eba517 ("ss: show header for --processes/-p")
> Signed-off-by: Brian Vazquez <brianvv@...gle.com>

This commit message is really hard to understand and causes warnings
in checkpatch. Also, blaming old code for doing the right thing
is not necessary. The changelog doesn't need to explain why.
The offending commit is already referenced by the fixes line.

Instead, I propose:


The previous change to ss to show header broke the printing of end-of-line
for the last entry.

Fixes: 5883c6eba517 ("ss: show header for --processes/-p")
Signed-off-by: Brian Vazquez <brianvv@...gle.com>