netdev - Re: [PATCH net v2 2/2] tcp: tighten acceptance of ACKs not matching a child socket

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANn89iJJZZxUoQYFOmWiFC7Xih6Nrz5DE6Z8-LZeU7Rip-qFAA@mail.gmail.com>
Date:   Thu, 5 Dec 2019 11:30:18 -0800
From:   Eric Dumazet <edumazet@...gle.com>
To:     Guillaume Nault <gnault@...hat.com>
Cc:     Eric Dumazet <eric.dumazet@...il.com>,
        David Miller <davem@...emloft.net>,
        Jakub Kicinski <jakub.kicinski@...ronome.com>,
        netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH net v2 2/2] tcp: tighten acceptance of ACKs not matching a
 child socket

On Thu, Dec 5, 2019 at 11:23 AM Guillaume Nault <gnault@...hat.com> wrote:
>

> Ok, I get it now. Thanks!
> Will send v3 using 'last_overflow - HZ' as lower bound.
>
> I think READ_ONCE()/WRITE_ONCE() are still necessary to prevent reloading
> and imaginary write of last_overflow. At least that's my understanding
> after reading memory-barriers.txt again.

Sure, it can not hurt, but please make this as a separate patch, thanks !