netdev - Re: [PATCH v2 net] hsr: fix a NULL pointer dereference in hsr_dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20191205.121006.1746994374411312901.davem@davemloft.net>
Date:   Thu, 05 Dec 2019 12:10:06 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     ap420073@...il.com
Cc:     xiyou.wangcong@...il.com, netdev@...r.kernel.org,
        treeze.taeung@...il.com
Subject: Re: [PATCH v2 net] hsr: fix a NULL pointer dereference in
 hsr_dev_xmit()

From: Taehee Yoo <ap420073@...il.com>
Date: Thu,  5 Dec 2019 07:23:39 +0000

> hsr_dev_xmit() calls hsr_port_get_hsr() to find master node and that would
> return NULL if master node is not existing in the list.
> But hsr_dev_xmit() doesn't check return pointer so a NULL dereference
> could occur.
> 
> Test commands:
 ...
> Splat looks like:
 ...
> Fixes: 311633b60406 ("hsr: switch ->dellink() to ->ndo_uninit()")
> Acked-by: Cong Wang <xiyou.wangcong@...il.com>
> Signed-off-by: Taehee Yoo <ap420073@...il.com>

Applied and queued up for v5.3 -stable, thanks.