netdev - Re: [PATCH net v2] net: Fixed updating of ethertype in skb_mpls

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20191204.171202.946324250971280038.davem@davemloft.net>
Date:   Wed, 04 Dec 2019 17:12:02 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     martinvarghesenokia@...il.com
Cc:     netdev@...r.kernel.org, pshelar@....org, jhs@...atatu.com,
        xiyou.wangcong@...il.com, jiri@...nulli.us,
        martin.varghese@...ia.com
Subject: Re: [PATCH net v2] net: Fixed updating of ethertype in
 skb_mpls_push()

From: Martin Varghese <martinvarghesenokia@...il.com>
Date: Thu,  5 Dec 2019 05:57:22 +0530

> From: Martin Varghese <martin.varghese@...ia.com>
> 
> The skb_mpls_push was not updating ethertype of an ethernet packet if
> the packet was originally received from a non ARPHRD_ETHER device.
> 
> In the below OVS data path flow, since the device corresponding to
> port 7 is an l3 device (ARPHRD_NONE) the skb_mpls_push function does
> not update the ethertype of the packet even though the previous
> push_eth action had added an ethernet header to the packet.
> 
> recirc_id(0),in_port(7),eth_type(0x0800),ipv4(tos=0/0xfc,ttl=64,frag=no),
> actions:push_eth(src=00:00:00:00:00:00,dst=00:00:00:00:00:00),
> push_mpls(label=13,tc=0,ttl=64,bos=1,eth_type=0x8847),4
> 
> Fixes: 8822e270d697 ("net: core: move push MPLS functionality from OvS to core helper")
> Signed-off-by: Martin Varghese <martin.varghese@...ia.com>
> ---
> Changes in v2:
>     Changed the subject line of patch.

Applied and queued up for -stable, thanks.