netdev - Re: [PATCH bpf] selftests/bpf: de-flake test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAADnVQKjVFxWK1VgQTkZp2+Swr=LD1Ar2ABMY3_=78nkjssoJA@mail.gmail.com>
Date:   Wed, 4 Dec 2019 18:01:53 -0800
From:   Alexei Starovoitov <alexei.starovoitov@...il.com>
To:     Stanislav Fomichev <sdf@...gle.com>
Cc:     Network Development <netdev@...r.kernel.org>,
        bpf <bpf@...r.kernel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Lawrence Brakmo <brakmo@...com>
Subject: Re: [PATCH bpf] selftests/bpf: de-flake test_tcpbpf

On Wed, Dec 4, 2019 at 11:09 AM Stanislav Fomichev <sdf@...gle.com> wrote:
>
> It looks like BPF program that handles BPF_SOCK_OPS_STATE_CB state
> can race with the bpf_map_lookup_elem("global_map"); I sometimes
> see the failures in this test and re-running helps.
>
> Since we know that we expect the callback to be called 3 times (one
> time for listener socket, two times for both ends of the connection),
> let's export this number and add simple retry logic around that.
>
> Also, let's make EXPECT_EQ() not return on failure, but continue
> evaluating all conditions; that should make potential debugging
> easier.
>
> With this fix in place I don't observe the flakiness anymore.
>
> Cc: Lawrence Brakmo <brakmo@...com>
> Signed-off-by: Stanislav Fomichev <sdf@...gle.com>

Applied. Thanks