lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Thu, 5 Dec 2019 11:03:31 +0800
From:   Yunsheng Lin <linyunsheng@...wei.com>
To:     "Li,Rongqing" <lirongqing@...du.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "saeedm@...lanox.com" <saeedm@...lanox.com>
Subject: Re: 答复: 答复: 答复: 答复: [PATCH] page_pool: mark unbound node page as reusable pages

On 2019/12/5 10:47, Li,Rongqing wrote:
>>
>> [1] https://lore.kernel.org/patchwork/patch/1125789/
> 
> 
> What is status of this patch? I think you should fix your firmware or bios

Have not reached a conclusion yet.

> 
> Consider the below condition:
> 
> there is two numa node, and NIC sites on node 2, but NUMA_NO_NODE is used, recycle will fail due to page_to_nid(page) == numa_mem_id(), 
> and reallocated pages maybe always from node 1, then the recycle will never success.

For page pool:

1. if the pool->p.nid != NUMA_NO_NODE, the recycle is always decided by
checking page_to_nid(page) == pool->p.nid.

2. only when the pool->p.nid == NUMA_NO_NODE, the numa_mem_id() is checked
   to decide the recycle.

Yes, If pool->p.nid == NUMA_NO_NODE, and the cpu that is doing recycling
is changing each time, the recycle may never success, but it is not common,
and have its own performance penalty when changing the recycling cpu so
often.


> 
> -RongQing
> 
> 

Powered by blists - more mailing lists