netdev - Re: [net PATCH] xdp: obtain the mem_id mutex before trying to remove an entry.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 04 Dec 2019 16:36:39 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     jonathan.lemon@...il.com
Cc:     netdev@...r.kernel.org, kernel-team@...com, brouer@...hat.com,
        grygorii.strashko@...com
Subject: Re: [net PATCH] xdp: obtain the mem_id mutex before trying to
 remove an entry.

From: Jonathan Lemon <jonathan.lemon@...il.com>
Date: Tue, 3 Dec 2019 14:01:14 -0800

> A lockdep splat was observed when trying to remove an xdp memory
> model from the table since the mutex was obtained when trying to
> remove the entry, but not before the table walk started:
> 
> Fix the splat by obtaining the lock before starting the table walk.
> 
> Fixes: c3f812cea0d7 ("page_pool: do not release pool until inflight == 0.")
> Reported-by: Grygorii Strashko <grygorii.strashko@...com>
> Signed-off-by: Jonathan Lemon <jonathan.lemon@...il.com>

Applied, and since this fixes a bug fix that went back to v5.3 in -stable
I will queue it there as well.

Thanks.