netdev - Re: [PATCH net] ionic: keep users rss hash across lif reset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20191204.164612.1086273679730587962.davem@davemloft.net>
Date:   Wed, 04 Dec 2019 16:46:12 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     snelson@...sando.io
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH net] ionic: keep users rss hash across lif reset

From: Shannon Nelson <snelson@...sando.io>
Date: Tue,  3 Dec 2019 14:17:34 -0800

> If the user has specified their own RSS hash key, don't
> lose it across queue resets such as DOWN/UP, MTU change,
> and number of channels change.  This is fixed by moving
> the key initialization to a little earlier in the lif
> creation.
> 
> Also, let's clean up the RSS config a little better on
> the way down by setting it all to 0.
> 
> Fixes: aa3198819bea ("ionic: Add RSS support")
> Signed-off-by: Shannon Nelson <snelson@...sando.io>

Looks good, applied and queued up for -stable.