netdev - RE: [PATCH V2 2/4] can: flexcan: try to exit stop mode during probe stage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DB7PR04MB461820120FF61E08B8B5B0B5E65C0@DB7PR04MB4618.eurprd04.prod.outlook.com>
Date:   Thu, 5 Dec 2019 11:19:45 +0000
From:   Joakim Zhang <qiangqing.zhang@....com>
To:     Sean Nyekjaer <sean@...nix.com>,
        Marc Kleine-Budde <mkl@...gutronix.de>,
        "linux-can@...r.kernel.org" <linux-can@...r.kernel.org>
CC:     dl-linux-imx <linux-imx@....com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: [PATCH V2 2/4] can: flexcan: try to exit stop mode during probe
 stage


> -----Original Message-----
> From: Sean Nyekjaer <sean@...nix.com>
> Sent: 2019年12月5日 19:12
> To: Joakim Zhang <qiangqing.zhang@....com>; Marc Kleine-Budde
> <mkl@...gutronix.de>; linux-can@...r.kernel.org
> Cc: dl-linux-imx <linux-imx@....com>; netdev@...r.kernel.org
> Subject: Re: [PATCH V2 2/4] can: flexcan: try to exit stop mode during probe
> stage
> 
> 
> 
> On 05/12/2019 12.04, Joakim Zhang wrote:
> > Hi Sean,
> >
> > At my side, both Power-On-Reset and reboot from console can get CAN-IP out
> of stop mode, HW is i.MX7D-SDB/i.MX8QXP-mek.
> > I think HW design could make difference.
> >
> > We more care about how does CAN-IP stuck in stop mode, could you please
> explain in details? We want figure out the root cause.
> 
> When running only with the first stop mode commit:
> de3578c198c6 ("can: flexcan: add self wakeup support") And there is incoming
> traffic on both CAN lines.
> I happens when going into suspend.
> Then the CAN-IP is stuck in stop mode..

That means with below patch then CAN-IP could not been stuck in stop mode, right?
	can: flexcan: fix deadlock when using self wakeup

If yes, I think we don't need check stop mode in probe stage, since issue has disappeared automatically.

> I'm on this custom i.MX6ull board.
> I have another custom board also with the i.MX6ull where the watchdog pins
> are wired to the PMIC.
> Will try to test on that next week

Okay, thanks.

Best Regards,
Joakim Zhang
> /Sean