netdev - Re: [PATCH 2/2] arm: omap2plus_defconfig: enable NET

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 6 Dec 2019 07:50:26 -0800
From:   Tony Lindgren <tony@...mide.com>
To:     Grygorii Strashko <grygorii.strashko@...com>
Cc:     Randy Dunlap <rdunlap@...radead.org>, netdev@...r.kernel.org,
        "David S . Miller" <davem@...emloft.net>,
        Sekhar Nori <nsekhar@...com>, linux-kernel@...r.kernel.org,
        linux-omap@...r.kernel.org
Subject: Re: [PATCH 2/2] arm: omap2plus_defconfig: enable NET_SWITCHDEV

* Grygorii Strashko <grygorii.strashko@...com> [191206 11:08]:
> Hi Tony,
> 
> On 04/12/2019 19:45, Grygorii Strashko wrote:
> > The TI_CPSW_SWITCHDEV definition in Kconfig was changed from "select
> > NET_SWITCHDEV" to "depends on NET_SWITCHDEV", and therefore it is required
> > to explicitelly enable NET_SWITCHDEV config option in omap2plus_defconfig.
> > 
> > Fixes: 3727d259ddaf ("arm: omap2plus_defconfig: enable new cpsw switchdev driver")
> > Signed-off-by: Grygorii Strashko <grygorii.strashko@...com>
> > ---
> >   arch/arm/configs/omap2plus_defconfig | 3 ++-
> >   1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/arch/arm/configs/omap2plus_defconfig b/arch/arm/configs/omap2plus_defconfig
> > index 89cce8d4bc6b..7bbef86a4e76 100644
> > --- a/arch/arm/configs/omap2plus_defconfig
> > +++ b/arch/arm/configs/omap2plus_defconfig
> > @@ -92,6 +92,7 @@ CONFIG_IP_PNP_BOOTP=y
> >   CONFIG_IP_PNP_RARP=y
> >   CONFIG_NETFILTER=y
> >   CONFIG_PHONET=m
> > +CONFIG_NET_SWITCHDEV=y
> >   CONFIG_CAN=m
> >   CONFIG_CAN_C_CAN=m
> >   CONFIG_CAN_C_CAN_PLATFORM=m
> > @@ -182,6 +183,7 @@ CONFIG_SMSC911X=y
> >   # CONFIG_NET_VENDOR_STMICRO is not set
> >   CONFIG_TI_DAVINCI_EMAC=y
> >   CONFIG_TI_CPSW=y
> > +CONFIG_TI_CPSW_SWITCHDEV=y
> >   CONFIG_TI_CPTS=y
> >   # CONFIG_NET_VENDOR_VIA is not set
> >   # CONFIG_NET_VENDOR_WIZNET is not set
> > @@ -554,4 +556,3 @@ CONFIG_DEBUG_INFO_DWARF4=y
> >   CONFIG_MAGIC_SYSRQ=y
> >   CONFIG_SCHEDSTATS=y
> >   # CONFIG_DEBUG_BUGVERBOSE is not set
> > -CONFIG_TI_CPSW_SWITCHDEV=y
> > 
> 
> Could it be applied as fix, as without it cpsw switch driver will not be built,
> so no networking on am571x-idk

OK I'll be applying it into fixes.

Thanks,

Tony