netdev - Re: [PATCH net] net: netlink: Fix uninit-value in netlink

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e24313a2-22c9-18da-4475-733157399975@cogentembedded.com>
Date:   Fri, 6 Dec 2019 21:57:09 +0300
From:   Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:     Håkon Bugge <haakon.bugge@...cle.com>
Cc:     "David S . Miller" <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: [PATCH net] net: netlink: Fix uninit-value in netlink_recvmsg()

On 12/06/2019 09:45 PM, Håkon Bugge wrote:

>>> If skb_recv_datagram() returns NULL, netlink_recvmsg() will return an
>>> arbitrarily value.
>>
>>   Arbitrary?
> 
> is an adjective.

   Yes. And it goes with the "value" noun.

> Since I described the verb *return*, I assumed the adverb,
> arbitrarily, is correct,

   In that case, it's misplaced, it should go before the verb.

> But english is not my native language.

   Not mine as well. :-)

> Thxs, Håkon

MBR, Sergei