netdev - Re: [PATCH v2 net] tipc: fix ordering of tipc module init and exit routine

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20191206.120221.133623350556751803.davem@davemloft.net>
Date:   Fri, 06 Dec 2019 12:02:21 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     ap420073@...il.com
Cc:     jon.maloy@...csson.com, ying.xue@...driver.com,
        netdev@...r.kernel.org
Subject: Re: [PATCH v2 net] tipc: fix ordering of tipc module init and exit
 routine

From: Taehee Yoo <ap420073@...il.com>
Date: Fri,  6 Dec 2019 05:25:48 +0000

> In order to set/get/dump, the tipc uses the generic netlink
> infrastructure. So, when tipc module is inserted, init function
> calls genl_register_family().
> After genl_register_family(), set/get/dump commands are immediately
> allowed and these callbacks internally use the net_generic.
> net_generic is allocated by register_pernet_device() but this
> is called after genl_register_family() in the __init function.
> So, these callbacks would use un-initialized net_generic.
> 
> Test commands:
 ...
> Splat looks like:
 ...
> Fixes: 7e4369057806 ("tipc: fix a slab object leak")
> Fixes: a62fbccecd62 ("tipc: make subscriber server support net namespace")
> Signed-off-by: Taehee Yoo <ap420073@...il.com>

Applied and queued up for -stable.